[WIP] Add WebView authentication #7924
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealeksandrov
added
the
feature: product details
ealeksandrov
force-pushed
the
issue/7911-webview-auth
branch
from
b70c42c to
d2091c2
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| } | ||
|
|
||
| extension WebKitViewController: WKUIDelegate { | ||
| func webView(_ webView: WKWebView, createWebViewWith configuration: WKWebViewConfiguration, for navigationAction: WKNavigationAction, windowFeatures: WKWindowFeatures) -> WKWebView? { |
There was a problem hiding this comment.
Line Length Violation: Line should be 160 characters or less: currently 187 characters (line_length)
| decisionHandler(.allow) | ||
| } | ||
|
|
||
| func webView(_ webView: WKWebView, decidePolicyFor navigationResponse: WKNavigationResponse, decisionHandler: @escaping (WKNavigationResponsePolicy) -> Void) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 160 characters or less: currently 163 characters (line_length)
|
|
||
| NSLayoutConstraint.activate(edgeConstraints) | ||
|
|
||
| // we are pinning the top and bottom of the stack view to the safe area to prevent unintentionally hidden content/overlaps (ie cookie acceptance popup) then center the horizontal constraints vertically |
There was a problem hiding this comment.
Line Length Violation: Line should be 160 characters or less: currently 209 characters (line_length)
Collaborator
You can test the changes from this Pull Request by:
|
Ecarrion
reviewed
Oct 25, 2022
| headers.forEach { (key, value) in | ||
| request.setValue(value, forHTTPHeaderField: key) | ||
| } | ||
| // request.setValue(WPUserAgent.wordPress(), forHTTPHeaderField: "User-Agent") |
Contributor
There was a problem hiding this comment.
Do we need to set up another user agent here?
Contributor
Author
There was a problem hiding this comment.
I don't see a reason for that. Nothing changed when I copy-pasted exact user-agent string from WP.
Without explicit setter it will be same as default: WooCommerce/10.8.0.0 CFNetwork/1390 Darwin/22.1.0.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7911
Description
This PR adds code from WP app to correctly authenticate user in the webview.
We need only atomic and self-hosted sites support, so we don't have to reimplement all the flows.
Video
RPReplay_Final.mp4